Adds support for docker-in-docker cross platform builds #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes 3 main changes:
host-home-mount. This input, if given, will be prepended to the paths of the repository itself and therun-maturin-action.shscript on the left side (host side) of the volume mounts when building in docker. This tries to solve issue Support for Manylinux in a Docker-in-Docker runner #265 where it is impossible to build cross platform wheels in a dockerized self-hosted runner. I'm not sure about the naming of this new input, open to new propositions.run-maturin-action.shscript from the /tmp folder of the runner machine to the ~/_work/_temp folder of the runner itself stored in the RUNNER_TEMP env variable. This seems more prudent as the file gets cleaned up by the job itself and not by the host.sudowhen the runner is running as root already.